Conversation
updated config to 3.3.0
used .replace to fix the improperly escaped inputvalues
removed Chr(32) syntax as 5.5 wouldnt accept it
|
control currently did not behave correctly when double quotes ("") were included in either a single response list, or in a JS file when using the ADC in an open ended loop. main culprit was the single.html and open.html files where the input value being saved was not properly escaping problematic HTML values such as &, %, "", etc. Fix was made to properly catch and escape these values so the data could be visualized and saved via the JS element. |
There was a problem hiding this comment.
Pull request overview
Updates the AutoComplete ADC to better tolerate double quotes/special characters in suggestion values and initial input values, while bumping the packaged artifact/version metadata.
Changes:
- Escape suggestion values when rendering
data-*attributes and decode before consumption inauto-complete.js. - Rework
single.html/open.htmlto pre-escape some values and populate the visible input’s value via a hidden text node + JS. - Bump version/date metadata and include an updated packaged
bin/AutoComplete.adc.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/static/auto-complete.js | Adds attribute escaping/decoding helpers and applies them to data-val / data-fullval. |
| resources/dynamic/single.html | Adds “safe” variables + manual escaping; sets visible input value via hidden span + JS; duplicates window.value assignment. |
| resources/dynamic/open.html | Similar escaping/value-population changes; window.value script emitted inside loop. |
| config.xml | Version/date bump; minor whitespace change. |
| changelog.md | Adds v3.3.0/v3.3.1 entries (with future dates + formatting/spelling issues). |
| bin/AutoComplete.adc | Adds packaged ADC artifact (currently treated as text by git). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.